Simplify dlls/atl/registrar.c

Gerald Pfeifer gerald at pfeifer.com
Sun Sep 21 05:42:13 CDT 2008


On Tue, 9 Sep 2008, Rob Shearman wrote:
>> -static HRESULT Registrar_create(const IUnknown *pUnkOuter, REFIID riid, void **ppvObject)
>> +static HRESULT Registrar_create(REFIID riid, void **ppvObject)
> A test needs to be added to see whether or not the Registrar class
> factory supports aggregation. If it does then a FIXME should be
> emitted. If not then an ERR may be emitted and CLASS_E_NOAGGREGATION
> returned. Just removing pUnkOuter isn't the right thing to do.

Fair point!  Sadly, this is beyond my expertise in this area and I hope
that someone with that expertise is going to help with that?

Is this something you could look at?  (Based on your analysis consider 
my patch redrawn...)

Gerald



More information about the wine-devel mailing list