[PATCH] shell32: print the correct GUIDs in the shellpath tests.

Maarten Lankhorst m.b.lankhorst at gmail.com
Sun Sep 28 14:00:35 CDT 2008

Hi Juan,

2008/9/28, Juan Lang <juan.lang at gmail.com>:
> Hi Reece, I'm not nak'ing your patch.  I just wanted to point out a simpler
> way:
> -static const char *printGUID(const GUID *guid)
> +static char *printGUID(const GUID *guid)
>  {
> -    static char guidSTR[39];
> +    char *guidSTR = HeapAlloc(GetProcessHeap(), 0, 39);
> Rather than allocating the necessary buffer, you can pass a pointer to
> a buffer to printGUID, and have printGUID return that buffer.  Have
> the caller declare two GUID buffers, and pass one for the expected
> value and the other for the received value.
This will cause a valgrind warning, so I don't think it should be a
recommended fix.


More information about the wine-devel mailing list