implement PS_USERSTYLE handling - obviously not correct ;)

John Klehm xixsimplicityxix at
Sat Apr 4 17:13:50 CDT 2009

On Sat, Apr 4, 2009 at 4:49 PM, Hans Breuer <hans at> wrote:
> Hi,
> just read again and noticed that my
> first wine patch may fall in the category of not deserving an answer at all
> (to your standards).

Not always the case. It could be just that no one is familiar enough
with that exact part of the code to provide feed back at a glance.

> But before resending it, I would appreciate some feedback if something else
> is 'obviously' wrong with it. To me it seems to be very difficult for the
> issue at hand to fall into the category of being "Obvious(ly) Correct".

> What can I do to increase the probability of the patch being accepted?

Adding test cases goes along way towards being obviously correct and
getting accepted into mainstream wine.

--John Klehm

More information about the wine-devel mailing list