implement PS_USERSTYLE handling, tested with Dia(win32)

Hans Breuer hans at breuer.org
Fri Apr 10 04:37:00 CDT 2009


At 05.04.2009 23:54, James McKenzie wrote:
> Hans Breuer wrote:
>> From b89af7d06fc8cbf5210c61fd58ed62caeddad968 Mon Sep 17 00:00:00 2001
>> From: Hans Breuer <hans at breuer.org>
>> Date: Sun, 29 Mar 2009 18:27:29 +0200
>> Subject: implement PS_USERSTYLE handling, tested with Dia(win32) - see
>>  http://hans.breuer.org/dia/dia-wine.htm
>>
>> ---
>>  dlls/winex11.drv/pen.c |   31 +++++++++++++++++++++++++++----
>>  1 files changed, 27 insertions(+), 4 deletions(-)
>>
[...]
>>
> This needs a conformance test to show this is what happens in Windows. 
> If this is not supported in certain versions, you will also need to add
> broken() code for those versions with what happens.  Look at the Wine
> source code and search for the use of this call.
> 
The only broken() calls I found are in */test/*. If I understood correctly 
for PS_USERSTYLE and ExtCreatePen these tests are allready there, see:
   dlls/gdi32/tests/pen.c

And they are un-effected by my patch, which is not changing any API 
behaviour, but just fixes the implementation to finally match the API.

Or am I still missing something?

Thanks,
	Hans

-------- Hans "at" Breuer "dot" Org -----------
Tell me what you need, and I'll tell you how to
get along without it.                -- Dilbert



More information about the wine-devel mailing list