[4/4] (Try4) msi/tests: Fix package test when run on root drive directory.

James Hawkins truiken at gmail.com
Fri Apr 10 18:43:10 CDT 2009

On Fri, Apr 10, 2009 at 2:36 PM, Nicolas Le Cam <niko.lecam at gmail.com> wrote:
> 2009/4/10, James Hawkins <truiken at gmail.com>:
>> On Fri, Apr 10, 2009 at 6:15 AM, Nicolas Le Cam <niko.lecam at gmail.com>
>> wrote:
>>> Try2: This time with the patch.
>>> Tested on Win2k/WinXP. Marked two tests as todo_wine.
>> I was serious before.  You can't change the old tests.  Please add new
>> tests for the exposed bugs.  Same goes for patch 3/4.
>> --
>> James Hawkins
> I will for test 4 but test 3 wasn't correct before. It was assuming
> drive was current one and that wasn't correct as revealed by my patch.
> This was only right if run on systemdrive and not from root drive dir.

You're missing the point.  Even in 3/4 you are adding a todo_wine
where there was none before.  By definition, you are changing what is
being tested.  The test was not incorrect, it just didn't cover all
corner cases.  Like I said before, I have no problem with you adding a
new test to tickle this bug you've found, but in your attempts to
'fix' the test for this corner case, you cannot add a todo_wine here.
This requires you to acquire a deeper understanding of what is being
tested instead of blindly throwing new code at the test.

James Hawkins

More information about the wine-devel mailing list