[2/2] secur32/tests: Fix GetUserNameEx() tests (try 2)

Kai Blin kai.blin at gmail.com
Tue Apr 14 06:17:13 CDT 2009

On Tuesday 14 April 2009 12:39:51 Ge van Geldorp wrote:

Hi Ge,

> > Why did you remove:
> >
> > -    if (0) /* Crashes on Windows */
> > -        rc = pGetUserNameExW(NameSamCompatible, NULL, NULL);
> > -
> >
> > The point of these additions was to show/document that Windows crashes
> > when called like this.
> Because Alexandre told me for an earlier patch to remove tests that crash
> on Windows:
> http://www.winehq.org/pipermail/wine-devel/2009-January/072010.html

What Paul meant is that as this test is behind an if(0), it's not going to be 
run anyway. So all it does is to serve as documentation of Windows behaviour.
Arguably, this could just be a comment, ideally in the implementation of 
GetUserNameExW, but in general it's nice to have this sort of information.


Kai Blin
WorldForge developer  http://www.worldforge.org/
Wine developer        http://wiki.winehq.org/KaiBlin
Samba team member     http://www.samba.org/samba/team/
Will code for cotton.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20090414/a8037b0a/attachment.pgp>

More information about the wine-devel mailing list