oleaut32: [Patch 1/2] VarCat must use localized names for VT_BOOL
Paul Vriens
paul.vriens.wine at gmail.com
Wed Apr 15 06:37:44 CDT 2009
Detlef Riekenberg wrote:
> http://test.winehq.org/data/f212579ae9a1b770ebd34cec20f95e1977bb57f0/xp_dr-asus/oleaut32:vartest.html
>
> While reading the code for a test failure on all of my Windows
> installations,
> the current code was already strange:
>
> 5436 ok(hres == VARCMP_EQ ||
> 5437 broken(hres == VARCMP_GT), "Expected VARCMP_EQ, got %08x\n",
> hres);
>
> I feel bad for adding a "broken(hres == VARCMP_LT)".
>
> Extending vartest and inserting a trace made the localization error
> obvisious:
> VARCMP_LT was returned when comparing "12Falsch" and "12False".
>
> The failure for the similar test (VT_BOOL with True: "12Wahr" >
> "12True")
> was hidden by the wrong "broken(hres == VARCMP_GT)".
>
> We have also another XP Machine that produced this failure.
> (xp-home-SP2-czech)
>
>
>
>
> ------------------------------------------------------------------------
>
>
Hi Detlef,
The lstrcpyW and lstrcatW additions to init() in the tests don't work on
Win95. I guess that's where the new failures come from:
http://test.winehq.org/data/ed74088d7ddf0c389e7596237add7cb751b17a0a/95_W95/oleaut32:vartest.html
Could you have a look?
--
Cheers,
Paul.
More information about the wine-devel
mailing list