[PATCH 1/2] comctl32/tests: test toolbar separator with uninitialized iString

[Paul Vriens]

Giuseppe Bilotta wrote:
> 2009/4/23 Mikołaj Zalewski <mikolaj at zalewski.pl>:
>>  Hi,
>>  I think it would be interesting to test what TB_GETBUTTONINFO returns as
>> iString for such a separator. That way we will know if the value is simply
>> ignored, or it's something more complicated.
> 
> You're definitely on to something here. Indeed, trying to get the TEXT
> button info causes a crash in Windows XP and Vista. Of course, during
> normal usage nobody is going to have a look at the iString of a
> separator.
> 
>>> +static void test_deadbeef(void)
>>>
>>  I think you should find a better name. Maybe test_addbuttons would be
>> better - some more tests for this message could be added later?
> 
> As per your suggestion, I named it test_invalidstring
> 
>>  Tests with #if 0 are discouraged - usually after some time and changes in
>> the surrounding, the code doesn't compile anymore. Probably leaving only the
>> comment would be appropriate in this case.
> 
> On #wine-devel it was suggested that #if 0 is the appropriate choice
> for tests that (can) crash on Windows. I think that having the code
> around, ready for testing, would be appropriate, at the very least
> until we decide what the Wine behaviour in these cases should be.
> 

if (0) would be better in that case as code will still be compiled.

-- 
Cheers,

Paul.