ole32: CoGetTreatAsClass should return S_FALSE if it cannot even find the key for the requested CLSID
Paul Vriens
paul.vriens.wine at gmail.com
Thu Apr 23 10:13:10 CDT 2009
Aric Stewart wrote:
>
> Fixes issues with IE7 involving constant prompting to click to run
> ActiveX controls when none are present
> Includes test
> ---
> dlls/ole32/compobj.c | 3 +++
> dlls/ole32/tests/compobj.c | 18 ++++++++++++++++++
> 2 files changed, 21 insertions(+), 0 deletions(-)
>
>
>
> ------------------------------------------------------------------------
>
>
Wouldn't it be better to use some other GUID here:
+ hr = pCoGetTreatAsClass(&GUID_NULL,&out);
+ ok (hr == S_FALSE, "expected S_FALSE got %x\n",hr);
+ ok (IsEqualGUID(&out,&GUID_NULL), "expected to get same clsid back\n");
That way we would know if Windows indeed leaves the clsid alone or
returns the NULL GUID?
Something like:
static GUID deadbeef =
{0xdeadbeef,0xdead,0xbeef,{0xde,0xad,0xbe,0xef,0xde,0xad,0xbe,0xef}};
--
Cheers,
Paul.
More information about the wine-devel
mailing list