ole32: CoGetTreatAsClass should return S_FALSE if it cannot even find the key for the requested CLSID

Aric Stewart aric at codeweavers.com
Thu Apr 23 10:16:44 CDT 2009


Good point, actually it should not be leaving the clsid alone it should 
be duplicating the requested GUID into it. (wine already does this part)

I will update the test to properly show that.

-aric
Paul Vriens wrote:
> Aric Stewart wrote:
>>
>> Fixes issues with IE7 involving constant prompting to click to run 
>> ActiveX controls when none are present
>> Includes test
>> ---
>>  dlls/ole32/compobj.c       |    3 +++
>>  dlls/ole32/tests/compobj.c |   18 ++++++++++++++++++
>>  2 files changed, 21 insertions(+), 0 deletions(-)
>>
>>
>>
>> ------------------------------------------------------------------------
>>
>>
> Wouldn't it be better to use some other GUID here:
> 
> +    hr = pCoGetTreatAsClass(&GUID_NULL,&out);
> +    ok (hr == S_FALSE, "expected S_FALSE got %x\n",hr);
> +    ok (IsEqualGUID(&out,&GUID_NULL), "expected to get same clsid 
> back\n");
> 
> That way we would know if Windows indeed leaves the clsid alone or 
> returns the NULL GUID?
> 
> Something like:
> 
> static GUID deadbeef = 
> {0xdeadbeef,0xdead,0xbeef,{0xde,0xad,0xbe,0xef,0xde,0xad,0xbe,0xef}};
> 



More information about the wine-devel mailing list