[1/3] winex11.drv: Support KEYEVENTF_UNICODE in SendInput

Andrew Eikum aeikum at codeweavers.com
Fri Aug 7 10:57:29 CDT 2009


Vitaliy Margolen wrote:
> Andrew Eikum wrote:
>> ---
> 
> Why did you swapped setting internal key state and calling hook in
> X11DRV_send_keyboard_input()? Do you have a test to check that state is
> being updated _before_ calling hook, and not after?
> 
> Vitaliy.

Good point. The MSDN hook documentation implies that the hook call 
should happen before any state changes, and I don't have any reason to 
change it.  After fixing that, was there anything else obviously wrong? 
  Otherwise I'll re-send the attached patch.

Thanks
Andrew


More information about the wine-devel mailing list