cppcheck run against 1.27

Marcus Meissner marcus at jet.franken.de
Sat Aug 8 03:56:22 CDT 2009


On Fri, Aug 07, 2009 at 06:36:36PM -0700, chris ahrendt wrote:
> 
> [../wine-git/dlls/ntdll/server.c:802]: (error) Resource leak: fd

I do not fully understand the code (keep fd open to have to lock
existing?), but it is in a fatal exit path.

> [../wine-git/tools/fnt2bdf.c:219]: (error) Resource leak: fp
> [../wine-git/tools/fnt2bdf.c:653]: (error) Resource leak: fd

Fix submitted, seem necessary.

> [../wine-git/tools/fnt2fon.c:304]: (error) Memory leak: file_lens

Fix submitted, but program is shortlived.

> [../wine-git/tools/widl/write_msft.c:2540]: (error) Deallocating a 
> deallocated pointer: fd

I do not understand what it mislikes about it. I think the detection
is wrong.

> [../wine-git/tools/winebuild/res16.c:187]: (error) Resource leak: fd

Fix submitted. Small issue though.

> [../wine-git/tools/winedump/pe.c:1549]: (error) Memory leak: map

Fix submitted. Small issue though.

Ciao, Marcus



More information about the wine-devel mailing list