Weekly cppcheck run against Aug 27 Git Tree

[Ben Klein]

2009/8/28 chris ahrendt <celticht32 at yahoo.com>:
> Mike Kaplinskiy wrote:
>> On Thu, Aug 27, 2009 at 3:52 PM, chris ahrendt<celticht32 at yahoo.com> wrote:
>>
>>> This is the result of running cppcheck 1.35 with the --all parm against
>>> the august 27th Git tree:
>>>
>>> [../wine-git/dlls/dbghelp/msc.c:88]: (possible error) Array index out of
>>> bounds
>>> [../wine-git/dlls/dbghelp/msc.c:89]: (possible error) Array index out of
>>> bounds
>>>
>>
>> False positive, apparently the numbers are hardcoded as:
>> 72     char        msg[128];
>> 88         msg[10 + 3 * 16] = ' '; // = 58<127
>> 89         msg[10 + 3 * 16 + 1 + 16] = '\0'; // = 75<127
>
> Mike While yes the hard coded one above is a false positive... I would
> argue its still a bug that probably needs to get fixed...

I don't follow this logic. How is it a bug (in Wine) exactly?