[PATCH 6/7] ws2_32: implement AcceptEx
Mike Kaplinskiy
mike.kaplinskiy at gmail.com
Fri Aug 28 13:14:43 CDT 2009
On Fri, Aug 28, 2009 at 2:01 PM, Juan Lang<juan.lang at gmail.com> wrote:
> Hi Mike, I have one minor nit on this patch:
>
> + if (wsa->read) HeapFree( GetProcessHeap(), 0, wsa->read );
> Please don't check if (wsa->read) is NULL before calling HeapFree.
> HeapFree already does the correct thing given NULL, and we had a bunch
> of patches to remove checks like this.
> --Juan
>
I did not know that, thanks Juan. I'll resend the batch.
Mike.
More information about the wine-devel
mailing list