listview: Fix LISTVIEW_CancelEditLabel to not save the changed text

Jeff Latimer lats at
Sun Dec 6 04:09:20 CST 2009

On 06/12/09 18:56, Nikolay Sivov wrote:
> Jeff Latimer wrote:
>> ---
>>  dlls/comctl32/listview.c       |    2 +-
>>  dlls/comctl32/tests/listview.c |    2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
> Hi, Jeff.
> This is obviously wrong. Test will fail on native systems after your 
> patch.
Why do you say that?  It tests ok on XP.  It was not being run on XP due to
if (!load_v6_module(&ctx_cookie, &hCtx))
so it looked if it was executing ok.  When I forced it to run, the 
original failed.  In any case the test comment says it is to check that 
the string "test" does not become "test1", however the test is
ok(strcmp(buff, test1) == 0, "Expected label text not to change\n");
which is the opposite.
> What is a problem with current code, any bugs reported?
No bug.

More information about the wine-devel mailing list