UNC Pathname handling

Alexandre Hardy alexandre.hardy at gmail.com
Fri Dec 11 04:25:58 CST 2009


Hi Paul,

> Don't think this memset makes sense as you do lstrcpyW after that (and yes
> it does not make sense in the A-test I did either ;) ).

Okay, that can be removed...

> You're saying that length should be 0 but the test tests something else.

WIll correct that (copy and paste -> I was in too much of a hurry)

>
>> +
>> +    memset(shortpath, 0, MAX_PATH * sizeof(WCHAR));
>> +    memset(longpath, 0, MAX_PATH * sizeof(WCHAR));

I should remove that as well :)

>
> You're setting longpath but it's not used anymore after that.
>
>> +    lstrcpyW(shortpath, uncprefix);
>> +    GetShortPathNameW(shortpath + 4, tempfile, MAX_PATH - 4);
>> +    length = pGetLongPathNameW(shortpath,NULL,0);
>
> This doesn't make sense to me. You are fill tempfile but not using it
> afterwards and then you call pGetLongPathNameW with NULL?

Yes, sorry, that should be
GetShortPathNameW(tempfile, shortpath + 4, MAX_PATH - 4);

> These are added tests but Wine crashes right now with these?

Yes, wine crashes right now with these.

Kind regards
Alexandre


-- 
--------------------------------------------------
Alexandre Hardy
http://www.ahardy.za.net



More information about the wine-devel mailing list