[PATCH] inetcomm/smtptransport.c : Remove some unneeded variables and assigns.
truiken at gmail.com
Wed Dec 16 13:23:25 CST 2009
On Wed, Dec 16, 2009 at 11:09 AM, Juan Lang <juan.lang at gmail.com> wrote:
> Hi Amine,
> this patch has no functional benefit. For example,
> - HRESULT hr;
> - hr = SMTPTransport_ParseResponse(This, pBuffer, &response);
> - if (FAILED(hr))
> + if (FAILED(SMTPTransport_ParseResponse(This, pBuffer, &response)))
> This has the dubious benefit of removing a local variable that was
> used before. I can't fathom why this is a good thing.
Also, you should never pass a function to a macro. What if FAILED
were defined as:
FAILED(x) (x & MASK1) | (x & MASK2)
More information about the wine-devel