comdlg32: Check if the shell view exists before using it to execute commands
paulc at voip.null.ro
Sat Dec 19 13:52:07 CST 2009
On Saturday 19 December 2009 08:19:03 pm Nikolay Sivov wrote:
> On 12/19/2009 20:47, Paul Chitescu wrote:
> > Changelog:
> > comdlg32: Check if the shell view exists before using it to execute
> > Prevents crashing if trying to create new folder with a R/O Registry
> > a bug by itself in a different module).
> Don't you mind add a test for that and previous patches?
Those functions are internal implementation of commdlg32.dll functionality so
they cannot be tested. The crash is not caused by any call parameters but
improper internal handling of an error condition during window creation.
The initialization is performed inside WM_INITDIALOG so that cannot report a
proper failure back to the application. It could immediately post a WM_DESTROY
but that would be almost as bad as the crash (and more confusing to the end
More information about the wine-devel