[PATCH 3/4] kernel32/path: Fix last error in SearchPathA/W with tests
Nikolay Sivov
bunglehead at gmail.com
Mon Dec 21 08:37:19 CST 2009
On 12/21/2009 17:21, Paul Vriens wrote:
> On 12/21/2009 02:32 AM, Nikolay Sivov wrote:
>> Fix last error in SearchPathA/W with tests
>>
> Hi Nikolay,
>
> Any reason all tests are relying on both the A- and W-version being
> available?
>
MSDN lied again, it's documented to be available in win2k.
> SearchPathA is implemented on Win98. SearchPathW is exported but not
> implemented. This means the current tests will fail on Win98 for example:
>
> path.c:1490: Test failed: Expected ERROR_INVALID_PARAMETER, got 2
> path.c:1497: Test failed: Expected ERROR_INVALID_PARAMETER, got 78
> path.c:1504: Test failed: Expected ERROR_INVALID_PARAMETER, got 78
>
> So SearchPathA returns something different for the last error and the
> SearchPathW tests already fail because GetWindowsDirectoryW() is not
> implemented (next to SearchPathW itself not being implemented of course).
>
I see, probably it's better to determine win9x indirectly here, to avoid
not obvious checks, I'll take a look for tomorrow
patch set, playing with testbot.
More information about the wine-devel
mailing list