[1/2] wininet: Always set last error in HttpSendRequest{,Ex}.
Paul Vriens
paul.vriens.wine at gmail.com
Tue Dec 22 05:24:48 CST 2009
On 12/21/2009 11:13 AM, Hans Leidekker wrote:
> + SetLastError(0xdeadbeef);
> r = HttpSendRequest(hr, NULL, 0, NULL, 0);
> + error = GetLastError();
> ok(r, "HttpSendRequest failed\n");
> + ok(error == ERROR_SUCCESS, "expected ERROR_SUCCESS, got %u\n", error);
Hi Hans,
This one introduces 5 (sometimes extra) failures on Win98/WinMe:
http://test.winehq.org/data/tests/wininet:http.html
Not all test_basic_request() fail btw:
test_basic_request(si.port, "GET", "/test1"); /* FAILS */
test_basic_request(si.port, "POST", "/test5"); /* FAILS */
test_basic_request(si.port, "RPC_IN_DATA", "/test5"); /* SUCCEEDS */
test_basic_request(si.port, "RPC_OUT_DATA", "/test5"); /* SUCCEEDS */
test_basic_request(si.port, "GET", "/test6"); /* FAILS */
test_basic_request(si.port, "GET", "/testF"); /* FAILS */
test_basic_request(si.port, "GET", "/quit"); /* FAILS */
For simplicity we could just add a broken() although that's not a 100%
correct. Or only use broken() when dealing with GEt/POST?
Thoughts?
--
Cheers,
Paul.
More information about the wine-devel
mailing list