dlls/user32/combo.c: Fix an issue where pressing 's' in a combobox shows the dropdown isntead of finding an entry starting with 's'.

Dmitry Timoshkov dmitry at codeweavers.com
Tue Dec 29 01:36:57 CST 2009

"David Quintana (gigaherz)" <gigaherz at gmail.com> wrote:

> Issue was caused by VK_F4 having the same exact code as a lowercase 's'.
> So the code, which treated WM_CHAR and WM_KEYDOWN as the same, executed
> the wrong piece of code which was meant to be ONLY for WM_KEYDOWN.

Thanks for spotting this bug. Anyway the fix is not correct. Virtual key
codes should be tested only in the WM_KEYDOWN handler, WM_CHAR handler
should test for character codes. Also, as Nikolay asked please don't use
C++ comments in Wine code.


More information about the wine-devel mailing list