dlls/user32/combo.c: Fix an issue where pressing 's' in a combobox shows the dropdown isntead of finding an entry starting with 's'.

David Quintana (gigaherz) gigaherz at gmail.com
Tue Dec 29 08:19:06 CST 2009

I had already sent a second patch without the C++-style comment. But
if you say other parts of the code are also wrong, then I will leave this to
closer to the project, who knows better what is it that should be done here.

2009/12/29 Dmitry Timoshkov <dmitry at codeweavers.com>

> "David Quintana (gigaherz)" <gigaherz at gmail.com> wrote:
>  Issue was caused by VK_F4 having the same exact code as a lowercase 's'.
>> So the code, which treated WM_CHAR and WM_KEYDOWN as the same, executed
>> the wrong piece of code which was meant to be ONLY for WM_KEYDOWN.
> Thanks for spotting this bug. Anyway the fix is not correct. Virtual key
> codes should be tested only in the WM_KEYDOWN handler, WM_CHAR handler
> should test for character codes. Also, as Nikolay asked please don't use
> C++ comments in Wine code.
> --
> Dmitry.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20091229/c0c9d2ee/attachment-0001.htm>

More information about the wine-devel mailing list