wintrust(3/3): Fix a couple tests on a variety of systems

Rob Shearman robertshearman at gmail.com
Fri Feb 13 08:21:50 CST 2009


2009/2/12 Juan Lang <juan.lang at gmail.com>:
> Hi Paul,
>
>> This is of course on boxes where people dont' run winetest as a
>> administrator. I'm not sure if ERROR_ACCESS_DENIED is thus actually an
>> acceptable failure. In other tests we have used skip() for this.
>
> Of course that's the reason, but not running as administrator is an
> acceptable configuration, is it not?

I don't think it should be. There are many variables that can be
changed that will cause test failures and this is one of them. We are
already putting a lot of effort into fixing tests that fail just
because of different versions of DLLs. We don't have the resources to
spend ensuring that the tests work in every possible configuration and
if many tests are skipped because of them being not being run as
Administrator then that isn't going to generate that much of a useful
test report.

Of course, we should find some way of preventing such reports being
filed and one of the ways could be to add a check to the winetest
program.

-- 
Rob Shearman



More information about the wine-devel mailing list