winetest: Annotate xmalloc() and xrealloc() with allocation size attribute.

Steven Edwards winehacker at gmail.com
Wed Feb 18 02:05:12 CST 2009


On Tue, Feb 17, 2009 at 10:40 PM, Dmitry Timoshkov
<dmitry at codeweavers.com> wrote:
> The reason why we avoid windows.h inclusion in Wine is compilation
> time by avoiding inclusion of all-in-one headers windows.h does. It's
> always a good programming practice to include only those .h files that
> are really needed, inclusion of windows.h usually shows the ignorance
> and lack of knowledge of a programmer.

I've agreed with the logic and the reasons behind it for the Wine
libraries. My point was that we already avoid it more than enough in
libraries, and maybe its a good thing after far as winelib goes to
insure the apps in the programs directory always do include windows.h
so that whenever someone does a true winelib port they don't have to
make unnecessary changes just to please Wine.

Maybe someone should drop those Chromium guys a note as they seem to
include windows.h in a lot of places....

-- 
Steven Edwards

"There is one thing stronger than all the armies in the world, and
that is an idea whose time has come." - Victor Hugo



More information about the wine-devel mailing list