[13/13] fusion: Add tests for the IAssemblyEnum interface.

Paul Vriens paul.vriens.wine at gmail.com
Thu Feb 19 14:21:28 CST 2009


Paul Vriens wrote:
> Hans Leidekker wrote:
>> Hi Paul,
>>
>>> These tests crash on Vista with .NET 3.5 (not sure about other 
>>> platforms/.NET versions yet). The enum_gac_assemblies function relies 
>>> on the fact that ffd.cFileName contains 2 underscores. On Vista 
>>> however I see some assemblies with a different format for the 
>>> cFileName like:
>>>
>>> 6.0.0.0_en_31bf3856ad364e35
>>
>> Yes, that test simply ignores the culture attribute. Is that one of your
>> own machines? If so, can you try this patch?
>>
>>  -Hans
>>
> At least we don't crash at that point (but still at the HeapFree). The 
> patch is not correct however as tracing shows in some cases:
> 
> Culture=en_31bf3856ad364e35
> 
> (and that makes sense reading the patch ;) )
> 
The second crash (HeapFree) is because we use strdup. Looks like on Windows 
strdup doesn't allocate memory on heap.

I guess we should replace strdup by a HeapAlloc/lstrcpyA ?

-- 
Cheers,

Paul.



More information about the wine-devel mailing list