setupapi/tests: Remove an unneeded cast.

Paul TBBle Hampson Paul.Hampson at Pobox.com
Thu Jan 8 04:46:28 CST 2009


On Thu, Jan 08, 2009 at 10:05:28AM +0100, Hans Leidekker wrote:
> On Thursday 08 January 2009 00:05:01 Francois Gouget wrote:

>>      memset(buffer, 0x55, sizeof(buffer));
>> -    retval = pStringTableLookUpStringEx(table, uilevel, ST_CASE_SENSITIVE_COMPARE, buffer, (LPDWORD)0);
>> +    retval = pStringTableLookUpStringEx(table, uilevel, ST_CASE_SENSITIVE_COMPARE, buffer, NULL);
>>      ok(retval != ~0u, "failed find 'UILEVEL' in string table\n");
>>      ok(memcmp(buffer, &data, 4), "unexpected data\n");

> This test is there to show that the prototype of StringTableLookUpStringEx
> is broken; the last parameter is treated as an integer instead of a pointer
> and this notation serves to document that fact.

Wouldn't that actually be different type sizes under Win64?

-- 
-----------------------------------------------------------
Paul "TBBle" Hampson, B.Sc, LPI, MCSE
Very-later-year Asian Studies student, ANU
The Boss, Bubblesworth Pty Ltd (ABN: 51 095 284 361)
Paul.Hampson at Pobox.com

Of course Pacman didn't influence us as kids. If it did,
we'd be running around in darkened rooms, popping pills and
listening to repetitive music.
 -- Kristian Wilson, Nintendo, Inc, 1989

License: http://creativecommons.org/licenses/by/2.5/au/
-----------------------------------------------------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-devel/attachments/20090108/7dbdcefe/attachment.pgp 


More information about the wine-devel mailing list