MSI Patch Feedback

Austin English austinenglish at
Fri Jan 9 11:10:29 CST 2009

On Fri, Jan 9, 2009 at 3:18 AM, Andrew Nguyen <arethusa26 at> wrote:
> Hello,
> I've written a few patches against dlls/msi/action.c in an effort to
> rectify a difference in behavior with an MSI-based installer between
> Windows and Wine with regard to environment variable processing.
> Behavior not explicitly enumerated by MSDN is noted when a combination
> of the environment table "+" name prefix and "[~]" value expression
> are combined. How should I attempt to test the changes I have made,
> and is there anything I can do to improve the quality of my changes?
> Feedback is appreciated!
> -Andrew

I don't see testcases for any of these changes. Adding conformance
tests would be the best first course of action:


More information about the wine-devel mailing list