mpr: fix a compiler error on PowerPC

Austin English austinenglish at gmail.com
Fri Jan 9 16:21:38 CST 2009


On Fri, Jan 9, 2009 at 4:17 PM, Francois Gouget <fgouget at free.fr> wrote:
> On Fri, 9 Jan 2009, Alexandre Julliard wrote:
>
>> Francois Gouget <fgouget at free.fr> writes:
>>
>> > On Fri, 9 Jan 2009, Alexandre Julliard wrote:
>> >
>> >> No, CHAR is really supposed to be the same thing as char, since it's
>> >> used for strings. Otherwise you'll need casts all over the place.
>> >
>> > Ideally we'd check whether 'char' was signed or unsigned in Visual C++
>> > for PowerPC (there was a Windows NT 3.51 for PowerPC). I doubt that
>> > Microsoft would have made it unsigned and then we'd need to do the same
>> > to really be source compatibile.
>>
>> Sure, but we would do that by adding -fsigned-char in winegcc, not by
>> making CHAR and char two different types.
>
> Oh. Good point. I forgot about that one. I guess that's a hint for
> Austin <g>...
>
>
> --
> Francois Gouget <fgouget at free.fr>              http://fgouget.free.fr/
>        War doesn't determine who's right.  War determines who's left.
>
>
>

I thought about doing that, but it seemed a bit heavy handed to me. If
Alexandre's fine with that, I'll send a patch.

I asked Stephen to ask ReactOS if anyone had a copy of Visual C++ for
Power PC, so maybe we can find out what M$ does there for char.

-- 
-Austin



More information about the wine-devel mailing list