[1/4] mshtml: Implement IHTMLStyle get/put borderRightStyle

Jacek Caban jacek at codeweavers.com
Sun Jan 11 13:25:35 CST 2009


Hi Alistair,

Alistair Leslie-Hughes wrote:
> Hi,
>
> Changelog:
>     mshtml: Implement IHTMLStyle get/put borderRightStyle
>

+static BOOL IsValidBorderStyle(BSTR v)


- Please use the same name convention as other functions in this file
- There is no test proving that the style is validated
- You didn't include get_borderRightStyle, which makes 
put_borderRightStyle almost useless

 static HRESULT WINAPI HTMLStyle_get_borderLeftStyle(IHTMLStyle *iface, BSTR *p)

That's not what changelog says.


Jacek
 





More information about the wine-devel mailing list