oleaut32/tests: add tests for OleLoadPictureFile(Ex) and OleLoadPicturePath (resend) [2/2]

Jeremy Drake wine at jdrake.com
Wed Jan 14 10:43:00 CST 2009


On Wed, 14 Jan 2009, Alexandre Julliard wrote:

> Jeremy Drake <wine at jdrake.com> writes:
>
> > Is there anything wrong with these two patches?  I'd really like to see
> > these tests go in, so hopefully someone will decide to tackle this
> > olepicture stuff.  At the very least, putting the stubs in for
> > OleLoadPictureFile (patch 1/2) keeps my app from crashing...
>
> Sorry but I'm not going to accept your patches in this area since you
> looked at the disassembled code. Probably your best bet is to file a bug
> about the missing function and hope that someone else picks it up.

Right.  That's why I abandoned writing a patch to implement the functions,
and instead focused on writing test cases so others could implement them.
Is writing test cases also verboten for someone who has seen disassembly?
It was my understanding that that was the acceptable way for me to move
forward with this.



More information about the wine-devel mailing list