Anything wrong with this patch?

Austin English austinenglish at gmail.com
Fri Jan 23 17:19:12 CST 2009


On Fri, Jan 23, 2009 at 4:58 PM, Jérôme Gardou <jerome.gardou at gmail.com> wrote:
> Ben Klein a écrit :
>> 2009/1/24 Jérôme Gardou <jerome.gardou at gmail.com>:
>>
>>> Ben Klein a écrit :
>>>
>>>> 2009/1/24 Jerome Leclanche <adys.wh at gmail.com>:
>>>>
>>>>
>>>>> (Damnit, gmail interface)
>>>>> Pipermail shows as empty, here.
>>>>>
>>>>> On Fri, Jan 23, 2009 at 10:05 PM, Jérôme Gardou <jerome.gardou at gmail.com>
>>>>> wrote:
>>>>>
>>>>>
>>>>>> http://www.winehq.org/pipermail/wine-patches/2009-January/067564.html
>>>>>> Any comment on this one? Related to bug 15616.
>>>>>>
>>>> Looks like
>>>> http://www.winehq.org/pipermail/wine-patches/2009-January/067564.html
>>>> has a brief description that says "See bug 15616", but the previous
>>>> mail http://www.winehq.org/pipermail/wine-patches/2009-January/067565.html
>>>> has the actual patch.
>>>>
>>>> Jérôme, be more careful when submitting patches! :)
>>>>
>>> strange... the first one is the original message, the second one looks like
>>> the attachment... Maybe something wrong with thunderbird. I'll resend if
>>> needed.
>>>
>>>
>>
>> I just looked at bug 15616. Maybe you should look at it too.
>>
>> Also, please hit "Reply to all" so your message gets sent to the
>> mailing list too :)
>>
>>
>>
> Of course... Austin English already noticed my patch. Austin, any idea
> why it was rejected?
>
> Sorry for the "reply to all", I forgot it this time...
>
>
>

I don't know. I only noticed the empty patch. AJ would be the one to ask.

Off hand though, I'd say if you're going to add support for .acm, you
should also allow for other native files. iexplore.exe is one
candidate, but probably controversial. There are other file extension
types missing, I'm sure, though not sure which types off hand.

-- 
-Austin



More information about the wine-devel mailing list