Implement BiDi mirroring

Khaled Hosny khaledhosny at eglug.org
Wed Jan 28 15:25:58 CST 2009


On Wed, Jan 28, 2009 at 11:22:04PM +0200, Khaled Hosny wrote:
> On Wed, Jan 28, 2009 at 01:00:43PM -0800, Juan Lang wrote:
> > Hi Khaled,
> > 
> > +void doMirror(WCHAR* ch)
> > 
> > This should be static.
> > 
> > +        else if(*ch == mirrored[k].first)
> > +            {
> > +                *ch = mirrored[k].mirror;
> > +                return;
> > +            }
> > 
> > The else if block is indented one level too many.
> 
> Both fixed.

Sorry, the patch was broken (I used git-diff --color!). I attached a new
one.

Regards,
 Khaled


-- 
 Khaled Hosny
 Arabic localizer and member of Arabeyes.org team
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bidi_mirror_2.diff
Type: text/x-diff
Size: 11588 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-devel/attachments/20090128/3a5626f9/attachment.diff 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
Url : http://www.winehq.org/pipermail/wine-devel/attachments/20090128/3a5626f9/attachment.pgp 


More information about the wine-devel mailing list