First complete test run passing on a Windows platform

[Florian Köberle]

Ge van Geldorp wrote:
>> From: Reece Dunn [mailto:msclrhd at googlemail.com] 
>>
>> Do you know why you need to do a SetForegroundWindow there to 
>> make the tests succeed?
>> Why is the input being sent to a different window?
>> Why does it vary from platform-to-platform and machine-to-machine?
>>     
>
> It's a timing issue. It doesn't just vary from machine-to-machine but even
> from testrun-to-testrun (e.g. gvg-wxpprosp2 failed on 29 Jan but passed on
> 27 Jan). This is on VMs which get reset to a snapshot before running the
> tests, so the machine starts each test run identically.
>
> Gé.
>   
I think the main problem is that the thread might run parallel with some
other test code.

That is why I would suggest to wait for the thread to finish at the end
of the test.

I made a patch and attached it to this email. I can't reproduce the
failure on my system, so I can't test if the patch helps. It would be
cool, if someone could test, if my patch fix the issue.

Best regards,
Florian Köberle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Make-sure-that-the-test-thread-doesn-t-run-while-oth.patch
Type: text/x-diff
Size: 0 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-devel/attachments/20090130/311d7ff3/attachment.patch