[2/2] mlang: Add a test for IMultiLanguage2_IsCodePageInstallable.

Paul Vriens paul.vriens.wine at gmail.com
Wed Jul 1 05:54:32 CDT 2009


Hans Leidekker wrote:
> On Wednesday 01 July 2009 12:12:47 pm Paul Vriens wrote:
> 
>>> Would using IsValidCodePage() be helpful here?
>>>
>> Yep, something like:
>>
>>          hr = IMultiLanguage2_IsCodePageInstallable(ml2, i);
>>          if (i == 29001 || /* win2k3 */
>>              i == 50930 || i == 50931 || i == 50933 || i == 50935 || i 
>> == 50937 || i == 50939 /* vista */)
>>          {
>>              ok(hr == S_FALSE || hr == S_OK || 
>> broken(!IsValidCodePage(i)), "%u: expected S_FALSE or S_OK, got 
>> 0x%08x\n", i, hr);
> 
> IsValidCodePage might be helpful yes, although marking it broken is
> a bit too strong I think, it's just a difference in codepage databases.
> 
>  -Hans
Yes, broken() seems strong but it's actually meant as 
behaviour_we_dont_want_to_replicate() in this case.

Using win_skip() would be nicer but that would mean way bigger report 
files. Maybe have a counter for skipped codepages and issue one 
win_skip() for all of them?

-- 
Cheers,

Paul.



More information about the wine-devel mailing list