[2/2] mlang: Add a test for IMultiLanguage2_IsCodePageInstallable.

Hans Leidekker hans at codeweavers.com
Wed Jul 1 06:56:01 CDT 2009


On Wednesday 01 July 2009 01:09:52 pm Alexandre Julliard wrote:

> >> IsValidCodePage might be helpful yes, although marking it broken is
> >> a bit too strong I think, it's just a difference in codepage databases.
> >>
> >>  -Hans
> > Yes, broken() seems strong but it's actually meant as
> > behaviour_we_dont_want_to_replicate() in this case.
> 
> I'm not convinced we don't want to replicate it. Using something like
> IsValidCodePage in the implementation would be better than hardcoding
> the list.

Some more testing suggests that the installable set is a superset of
the valid codepages set. So we could just return the set of valid
codepages for now and not hardcode anything.

 -Hans



More information about the wine-devel mailing list