user32: Windows test request (cursors/icons)

[Paul Vriens]

Daniel Santos wrote:
> I don't have access to a working windows machine right now and would appreciate if somebody can run these tests against XP, vista and/or 9x.
> 
> Thanks!
> Daniel
> 
Hi Daniel,

Tested on XP Professional SP3:

cursoricon.c:1367: Test failed: Last error is 1402 (0x57a), expected 
1414 (0x586).
cursoricon.c:1369: Test failed: Last error is 1402 (0x57a), expected 
1414 (0x586).
cursoricon.c:1371: Test failed: Last error is 1402 (0x57a), expected 
1414 (0x586).
cursoricon.c:184: Test failed: Last error is 1402 (0x57a), expected 1414 
(0x586).
cursoricon: 6 tests executed (0 marked as todo, 0 failures), 0 skipped.
cursoricon: 553 tests executed (0 marked as todo, 4 failures), 0 skipped.

NT4 Server SP6a:

cursoricon.c:1363: Test failed: DestroyCursor returned 1, expected FALSE.
cursoricon.c:1363: Test failed: Last error is 3735928559 (0xdeadbeef), 
expected 1402 (0x57a).
cursoricon.c:1367: Test failed: Last error is 1402 (0x57a), expected 
1414 (0x586).
cursoricon.c:1369: Test failed: DestroyIcon returned 1, expected FALSE.
cursoricon.c:1369: Test failed: Last error is 3735928559 (0xdeadbeef), 
expected 1414 (0x586).
cursoricon.c:1371: Test failed: Last error is 1402 (0x57a), expected 
1414 (0x586).
cursoricon.c:184: Test failed: Last error is 1402 (0x57a), expected 1414 
(0x586).
cursoricon: 6 tests executed (0 marked as todo, 0 failures), 0 skipped.
cursoricon: 553 tests executed (0 marked as todo, 7 failures), 0 skipped.

W2K Professional SP4:

cursoricon.c:1367: Test failed: Last error is 1402 (0x57a), expected 
1414 (0x586).
cursoricon.c:1369: Test failed: Last error is 1402 (0x57a), expected 
1414 (0x586).
cursoricon.c:1371: Test failed: Last error is 1402 (0x57a), expected 
1414 (0x586).
cursoricon.c:184: Test failed: Last error is 1402 (0x57a), expected 1414 
(0x586).
cursoricon: 6 tests executed (0 marked as todo, 0 failures), 0 skipped.
cursoricon: 553 tests executed (0 marked as todo, 4 failures), 0 skipped.

W2K3 SE SP2:

cursoricon.c:1367: Test failed: Last error is 1402 (0x57a), expected 
1414 (0x586).
cursoricon.c:1369: Test failed: Last error is 1402 (0x57a), expected 
1414 (0x586).
cursoricon.c:1371: Test failed: Last error is 1402 (0x57a), expected 
1414 (0x586).
cursoricon.c:184: Test failed: Last error is 1402 (0x57a), expected 1414 
(0x586).
cursoricon: 6 tests executed (0 marked as todo, 0 failures), 0 skipped.
cursoricon: 554 tests executed (0 marked as todo, 4 failures), 0 skipped.

Vista Ultimate - SP2:

cursoricon.c:1367: Test failed: Last error is 1402 (0x57a), expected 
1414 (0x586).
cursoricon.c:1369: Test failed: Last error is 1402 (0x57a), expected 
1414 (0x586).
cursoricon.c:1371: Test failed: Last error is 1402 (0x57a), expected 
1414 (0x586).
cursoricon.c:184: Test failed: Last error is 1402 (0x57a), expected 1414 
(0x586).
cursoricon: 11 tests executed (0 marked as todo, 0 failures), 0 skipped.
cursoricon: 553 tests executed (0 marked as todo, 4 failures), 0 skipped.

I get a blue screen on Win95 and Win98 (VMware issue?) !!

Some remarks on your patch:

- Please move the new functions to the top so you don't have to forward 
declare them.
- The level of comments for the 2 added functions is something we 
usually expect for implementations, not for tests ;)

-- 
Cheers,

Paul.