Try #2: user32: Windows test request (cursors/icons)

[Daniel Santos]

Thanks again for testing this for me, Paul.  I have modified the tests so that they should pass and I've skipped tests on win9x that I suspect are causing the blue screens (personally, I doubt it's due to VMware).

I moved the new test functions to the top of the file, but I didn't remove the comments.  I can shorten them if preferred, but I personally prefer to have functions well documented.

So if you or anybody else could test this again for me, I would greatly appreciate it.

Thanks!
Daniel

--- On Fri, 7/3/09, Paul Vriens <paul.vriens.wine at gmail.com> wrote:

> From: Paul Vriens <paul.vriens.wine at gmail.com>
> Subject: Re: user32: Windows test request (cursors/icons)
> To: daniel.santos at pobox.com
> Cc: wine-devel at winehq.org
> Date: Friday, July 3, 2009, 3:44 PM
> Daniel Santos wrote:
> > I don't have access to a working windows machine right
> now and would appreciate if somebody can run these tests
> against XP, vista and/or 9x.
> > 
> > Thanks!
> > Daniel
> > 
> Hi Daniel,
> 
> Tested on XP Professional SP3:
> 
> cursoricon.c:1367: Test failed: Last error is 1402 (0x57a),
> expected 1414 (0x586).
> cursoricon.c:1369: Test failed: Last error is 1402 (0x57a),
> expected 1414 (0x586).
> cursoricon.c:1371: Test failed: Last error is 1402 (0x57a),
> expected 1414 (0x586).
> cursoricon.c:184: Test failed: Last error is 1402 (0x57a),
> expected 1414 (0x586).
> cursoricon: 6 tests executed (0 marked as todo, 0
> failures), 0 skipped.
> cursoricon: 553 tests executed (0 marked as todo, 4
> failures), 0 skipped.
> 
> NT4 Server SP6a:
> 
> cursoricon.c:1363: Test failed: DestroyCursor returned 1,
> expected FALSE.
> cursoricon.c:1363: Test failed: Last error is 3735928559
> (0xdeadbeef), expected 1402 (0x57a).
> cursoricon.c:1367: Test failed: Last error is 1402 (0x57a),
> expected 1414 (0x586).
> cursoricon.c:1369: Test failed: DestroyIcon returned 1,
> expected FALSE.
> cursoricon.c:1369: Test failed: Last error is 3735928559
> (0xdeadbeef), expected 1414 (0x586).
> cursoricon.c:1371: Test failed: Last error is 1402 (0x57a),
> expected 1414 (0x586).
> cursoricon.c:184: Test failed: Last error is 1402 (0x57a),
> expected 1414 (0x586).
> cursoricon: 6 tests executed (0 marked as todo, 0
> failures), 0 skipped.
> cursoricon: 553 tests executed (0 marked as todo, 7
> failures), 0 skipped.
> 
> W2K Professional SP4:
> 
> cursoricon.c:1367: Test failed: Last error is 1402 (0x57a),
> expected 1414 (0x586).
> cursoricon.c:1369: Test failed: Last error is 1402 (0x57a),
> expected 1414 (0x586).
> cursoricon.c:1371: Test failed: Last error is 1402 (0x57a),
> expected 1414 (0x586).
> cursoricon.c:184: Test failed: Last error is 1402 (0x57a),
> expected 1414 (0x586).
> cursoricon: 6 tests executed (0 marked as todo, 0
> failures), 0 skipped.
> cursoricon: 553 tests executed (0 marked as todo, 4
> failures), 0 skipped.
> 
> W2K3 SE SP2:
> 
> cursoricon.c:1367: Test failed: Last error is 1402 (0x57a),
> expected 1414 (0x586).
> cursoricon.c:1369: Test failed: Last error is 1402 (0x57a),
> expected 1414 (0x586).
> cursoricon.c:1371: Test failed: Last error is 1402 (0x57a),
> expected 1414 (0x586).
> cursoricon.c:184: Test failed: Last error is 1402 (0x57a),
> expected 1414 (0x586).
> cursoricon: 6 tests executed (0 marked as todo, 0
> failures), 0 skipped.
> cursoricon: 554 tests executed (0 marked as todo, 4
> failures), 0 skipped.
> 
> Vista Ultimate - SP2:
> 
> cursoricon.c:1367: Test failed: Last error is 1402 (0x57a),
> expected 1414 (0x586).
> cursoricon.c:1369: Test failed: Last error is 1402 (0x57a),
> expected 1414 (0x586).
> cursoricon.c:1371: Test failed: Last error is 1402 (0x57a),
> expected 1414 (0x586).
> cursoricon.c:184: Test failed: Last error is 1402 (0x57a),
> expected 1414 (0x586).
> cursoricon: 11 tests executed (0 marked as todo, 0
> failures), 0 skipped.
> cursoricon: 553 tests executed (0 marked as todo, 4
> failures), 0 skipped.
> 
> I get a blue screen on Win95 and Win98 (VMware issue?) !!
> 
> Some remarks on your patch:
> 
> - Please move the new functions to the top so you don't
> have to forward declare them.
> - The level of comments for the 2 added functions is
> something we usually expect for implementations, not for
> tests ;)
> 
> -- Cheers,
> 
> Paul.
>


      
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-user32-Add-more-tests-for-SetCursor-DestroyCursor.txt
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20090705/a21e58d9/attachment-0001.txt>