Warnings on the translation page

[Paul Vriens]

Michael Stefaniuc wrote:
> Michael Stefaniuc wrote:
>> Michael Stefaniuc wrote:
>>> Paul Vriens wrote:
>>>> Hi,
>>>>
>>>> I found an anomaly on the translations page. Whenever the Makefile shows
>>>>  a generic rc file (last one added for RC_SRCS) the language before that
>>>> shows warnings on the page. Example:
>>>>
>>>> http://source.winehq.org/transl/lang.php?lang=004%3A01
>>>>
>>>> zh (Chinese (Traditional)) shows up most of the warning as the entries
>>>> in the Makefile are sorted.
>>>>
>>>> Not sure yet, if this is an issue with wrc or transl.
>>> wrc is fine; just tested it out with wrc --verify-translation.
>> Spoke too soon.
>>
>>> The errors shown are:
>>> ERR: resource 0002/1307 has translation(s) but not available in NEUTRAL
>>> or MASTER language
>>> ERR: resource 0002/104 has translation(s) but not available in NEUTRAL
>>> or MASTER language
>>> ERR: resource 0106/1312 has translation(s) but not available in NEUTRAL
>>> or MASTER language
>> This patch silences the errors:
>> diff --git a/programs/winecfg/winecfg.rc b/programs/winecfg/winecfg.rc
>> index df572fd..2424877 100644
>> --- a/programs/winecfg/winecfg.rc
>> +++ b/programs/winecfg/winecfg.rc
>> @@ -23,6 +23,8 @@
>>  #include "config.h"   /* Needed for the PACKAGE_STRING definition */
>>  #include "resource.h"
>>
>> +LANGUAGE LANG_NEUTRAL, SUBLANG_NEUTRAL
>> +
>>  /* @makedep: idb_wine.bmp */
>>  IDB_WINE BITMAP idb_wine.bmp
>>
>> With or without that line the generated resources are the same. So it
>> seems that the --verify-translation portion of wrc doesn't assign those
>> resources to the default "LANGUAGE LANG_NEUTRAL, SUBLANG_NEUTRAL" as it
>> should do.
> Found the problem: wrc doesn't reset the language after each rc file but
> keeps the last value. I have submitted a patch for that.
> 
>>> transl seems to assign those to the last language.
>> Nevertheless transl mis-parses those errors.
> transl is fine in the end.
> 
> bye
> 	michael

Great, thanks for looking into this.

-- 
Cheers,

Paul.