[3/3] WineD3D: Update the scissor rect on a render target change

Henri Verbeet hverbeet at gmail.com
Tue Jul 21 09:11:59 CDT 2009


2009/7/20 Henri Verbeet <hverbeet at gmail.com>:
> 2009/7/20 Stefan Dösinger <stefan at codeweavers.com>:
>> Am Monday 20 July 2009 12:58:16 schrieb Henri Verbeet:
>>> The MarkStateDirty() call looks redundant to me. Also, does this do
>>> the right thing when we're recording a stateblock?
>> It's not redundant because the scissor rect needs updating on a RT switch
>> anyway - I think it wasn't visible in this diff, but there is a SetViewport
>> call above the SetScissorRect which explains the situation.
>>
> Ok, but that's for a different reason then. Also, the wording of that
> comment could use some work.
>
Actually, that is already handled by FindContext(), although perhaps
"render_offscreen" should be tracked by the context rather than the
device.



More information about the wine-devel mailing list