Request for Review: Cursor & Icon patches

[Frédéric Delanoy]

On 07/25/2009 08:21 PM, Daniel Santos wrote:
>> Anyway Alexandre is on holiday next week, so you'll have to
>> wait a bit to get his comments.
> 
> Yea, that's what I was afraid of.
> 
> As far as the chunks, most of them do stand on their own with updated test code (one of them fails tests).
You should probably ensure all of your tests succeed if you want your code to be included.

>  I was considering submitting the patches in both the incremental form in addition to a single bulk patch.  I guess it doesn't matter too much since you can do that pretty easily in git anyway.
The purpose of separate patches is
- to ease review
- to ease regression testing

Submitting a bulk patch is unneeded since you can easily get diffs between arbitrary revisions in git.