[RESEND] mountmgr.sys: implement forced setting of fixed/local disk

Alexandre Julliard julliard at winehq.org
Thu Jun 4 04:06:45 CDT 2009

Ben Klein <shacklein at gmail.com> writes:

> From 100c129bbb1a3df3ebb68d52b22c798b6a2150c2 Mon Sep 17 00:00:00 2001
> From: Ben Klein <shacklein at gmail.com>
> Date: Fri, 6 Mar 2009 00:49:39 +1100
> Subject: mountmgr.sys: implement forced setting of fixed/local disk
> define_unix_drive in mountmgr.c includes all cases used in query_unix_drive
> except the DRIVE_FIXED == DEVICE_HARDDISK_VOL mapping. This patch fixes 17618
> where setting the drive type to "Local disk" in winecfg does not save the
> change to the registry.

The problem is that there are two kinds of disk devices, and
HARDDISK_VOL should only be used for things that have an actual device
associated, i.e. USB sticks and the like. Currently there's no way to
make that distinction in winecfg or in the registry.

I don't think we want to extend the existing mechanism because the
registry config needs to be changed anyway. There's a lot more
information that mountmgr needs to store beyond just hd/cdrom/floppy,
and extending the current scheme will only make it harder to change
while maintaining backwards compatibility.

Though I'd expect the current behavior to work fine since the harddisk
type is autodetected. Is there really a need to configure an explicit
HARDDISK_VOL device from winecfg, or is it just because it's there in
the winecfg dropdown?

Alexandre Julliard
julliard at winehq.org

More information about the wine-devel mailing list