Simplify code in dlls/imm32/tests/imm32.c

Joris Huizer joris_huizer at yahoo.com
Sat Jun 20 07:02:28 CDT 2009


Hello Gerald Pfeifer,

You did,

     /* behavior differs between win9x and NT */
     ret = ImmGetCompositionString(imc, GCS_COMPSTR, resstr, sizeof(resstr));
-    ok(ret || !ret, "You'll never read this.\n");
+    ok(TRUE, "You'll never read this.\n");
 
Wouldn't it be better to do something like:
     ok(ret || broken(!ret), "You'll never read this.\n");
or marking the other case broken()?
Note that broken() should be interpreted as, "unwanted functionality for Wine"

HTH,

Joris


      



More information about the wine-devel mailing list