[PATCH 2/2] mshtml: Fixed tests on IE8 and change Wine behavior to IE8.

Jacek Caban jacek at codeweavers.com
Mon Jun 22 12:24:56 CDT 2009


Hi Paul,

Paul Vriens wrote:
> This piece however doesn't look correct:
>
> +static void _test_disp2(unsigned line, IUnknown *unk, const IID 
> *diid, const IID *diid2)
> +{
> +    IID iid;
> +
> +    if(_test_get_dispid(line, unk, &iid))
> +        ok_(__FILE__,line) (IsEqualGUID(&iid, diid) || 
> broken(IsEqualGUID(&iid, diid)),
> +                "unexpected guid %s\n", dbgstr_guid(&iid));
>
> You are comparing twice against diid.
>


Right, good catch, the second test should compare against diid2.


Thanks,
    Jacek



More information about the wine-devel mailing list