[5/5] ws2_32/tests: Tests for invalid conditions in InetNtop
Jeff Latimer
lats at yless4u.com.au
Mon Mar 9 02:42:09 CDT 2009
Paul Vriens wrote:
> Jeff Latimer wrote:
>> MSDN defines an number of conditions that inet_ntop will return
>> errors. This patch tests for them.
>> -
> Secondly you shouldn't use magic number if you no the name:
>
> WSASetLastError(0xc000000d);
>
> In the tests you do:
>
> + ok(WSAGetLastError() == 0xC000000D,
> + "Should be ERROR_INVALID_PARAMETER not %x\n",
> WSAGetLastError());
>
> Again the magic number and in this case the ok() message is wrong as
> that should be STATUS_INVALID_PARAMETER according to your testing.
STATUS_INVALID_PARAMETER is defined in ntstatus.h and I did not think
that ntstatus.h was appropriate in ws2_32. What do you think? I can
put in easily enough.
More information about the wine-devel
mailing list