[ntdll] Care about empty fields of assembly_identity structure in actctx.c

Jacek Caban jacek at codeweavers.com
Wed Mar 11 12:33:59 CDT 2009


Hi Roman,

> On parsing of manifest in PE module is possible access to zero address
> and crash. It's happens because not all manifest attributes can be
> specified and pointers in assembly_identity structure can be
> uninitialized. This patch adds function for setting empty strings in
> structure elements when they not initialized.


Your patch looks like a workaround. You should fix the code to cope with 
NULL pointers correctly instead of allocating useless empty strings.
Also initialize_assembly_identity doesn't make sense. ai is initialized 
a few lines later by memset call.

Jacek



More information about the wine-devel mailing list