[shell32] Improve the Dutch 'about' message box

Paul Vriens paul.vriens.wine at gmail.com
Tue May 12 04:15:57 CDT 2009


Paul Vriens wrote:
> Reece Dunn wrote:
>> 2009/5/12 Paul Vriens <paul.vriens.wine at gmail.com>:
>>> Hi,
>>>
>>> Changed the sizes of the buttons and window to be the same as in
>>> English. This make sure the 'Wine license' button can be fully read in
>>> Dutch.
>>>
>>> - DEFPUSHBUTTON "OK", IDOK, 153, 133, 50, 12, WS_TABSTOP
>>> + DEFPUSHBUTTON "OK", IDOK, 153, 133, 60, 12, WS_TABSTOP
>>
>> According to Windows guidelines, command buttons
>> (http://msdn.microsoft.com/en-us/library/aa511453.aspx) should be 50 x
>> 14 DLUs (they can be wider than 50 DLUs, but only if the text is
>> bigger than that, which it shouldn't for OK buttons) and have a 4 DLU
>> spacing between other controls. This is so they look good in the
>> presence of themes.
>>
>> - Reece
> Maybe, but doing a simple grep shows:
> 
> shell32_Bg.rc: DEFPUSHBUTTON "OK", IDOK, 153, 133, 60, 12, WS_TABSTOP
> shell32_Cs.rc: DEFPUSHBUTTON "OK", IDOK, 153, 133, 60, 12, WS_TABSTOP
> shell32_Da.rc: DEFPUSHBUTTON "OK", IDOK, 153, 133, 60, 12, WS_TABSTOP
> shell32_De.rc: DEFPUSHBUTTON "OK", IDOK, 153, 133, 50, 12, WS_TABSTOP
> shell32_En.rc: DEFPUSHBUTTON "OK", IDOK, 153, 133, 60, 12, WS_TABSTOP
> shell32_Fi.rc: DEFPUSHBUTTON "OK", IDOK, 153, 133, 60, 12, WS_TABSTOP
> shell32_Fr.rc: DEFPUSHBUTTON "OK", IDOK, 153, 133, 70, 12, WS_TABSTOP
> shell32_Hu.rc: DEFPUSHBUTTON "OK", IDOK, 153, 133, 60, 12, WS_TABSTOP
> shell32_It.rc: DEFPUSHBUTTON "OK", IDOK, 153, 133, 60, 12, WS_TABSTOP
> shell32_Ja.rc: DEFPUSHBUTTON "OK", IDOK, 153, 133, 60, 12, WS_TABSTOP
> shell32_Nl.rc: DEFPUSHBUTTON "OK", IDOK, 153, 133, 60, 12, WS_TABSTOP
> shell32_No.rc: DEFPUSHBUTTON "OK", IDOK, 153, 133, 60, 12, WS_TABSTOP
> shell32_Pl.rc: DEFPUSHBUTTON "OK", IDOK, 153, 133, 60, 12, WS_TABSTOP
> shell32_Pt.rc: DEFPUSHBUTTON "OK", IDOK, 153, 133, 60, 12, WS_TABSTOP
> shell32_Pt.rc: DEFPUSHBUTTON "OK", IDOK, 153, 133, 60, 12, WS_TABSTOP
> shell32_Ro.rc: DEFPUSHBUTTON "OK", IDOK, 153, 133, 60, 12, WS_TABSTOP
> shell32_Ru.rc: DEFPUSHBUTTON "OK", IDOK, 153, 133, 60, 12, WS_TABSTOP
> shell32_Sk.rc: DEFPUSHBUTTON "OK", IDOK, 153, 133, 60, 12, WS_TABSTOP
> shell32_Sv.rc: DEFPUSHBUTTON "OK", IDOK, 153, 133, 60, 12, WS_TABSTOP
> shell32_Uk.rc: DEFPUSHBUTTON "OK", IDOK, 153, 133, 60, 12, WS_TABSTOP
> 
> The size of these OK buttons is probably aligned with the other button 
> in that window.
> 
I'm not against changing the size of that OK button to 50x14 but was 
merely pointing out that this means most of this stuff is not correct.

FWIW I was just looking at Outlook 2003 and the OK button on the about 
window is the same wide as the other buttons (not 50). The page you 
reference doesn't say anything about adjusting sizes of buttons when 
multiple (horizontally or vertically) can be found on one page (or at 
least I didn't see it).

-- 
Cheers,

Paul.



More information about the wine-devel mailing list