[shell32] Improve the Dutch 'about' message box

[Reece Dunn]

Paul Vriens wrote:
> Paul Vriens wrote:
>>
>> Reece Dunn wrote:
>>>
>>> According to Windows guidelines, command buttons
>>> (http://msdn.microsoft.com/en-us/library/aa511453.aspx) should be 50 x
>>> 14 DLUs (they can be wider than 50 DLUs, but only if the text is
>>> bigger than that, which it shouldn't for OK buttons) and have a 4 DLU
>>> spacing between other controls. This is so they look good in the
>>> presence of themes.
>>>
>>> - Reece
>>
>> Maybe, but doing a simple grep shows:
>>
>> shell32_Bg.rc: DEFPUSHBUTTON "OK", IDOK, 153, 133, 60, 12, WS_TABSTOP
>> shell32_Cs.rc: DEFPUSHBUTTON "OK", IDOK, 153, 133, 60, 12, WS_TABSTOP
>> shell32_Da.rc: DEFPUSHBUTTON "OK", IDOK, 153, 133, 60, 12, WS_TABSTOP
>> shell32_De.rc: DEFPUSHBUTTON "OK", IDOK, 153, 133, 50, 12, WS_TABSTOP
>> shell32_En.rc: DEFPUSHBUTTON "OK", IDOK, 153, 133, 60, 12, WS_TABSTOP
>> shell32_Fi.rc: DEFPUSHBUTTON "OK", IDOK, 153, 133, 60, 12, WS_TABSTOP
>> shell32_Fr.rc: DEFPUSHBUTTON "OK", IDOK, 153, 133, 70, 12, WS_TABSTOP
>> shell32_Hu.rc: DEFPUSHBUTTON "OK", IDOK, 153, 133, 60, 12, WS_TABSTOP
>> shell32_It.rc: DEFPUSHBUTTON "OK", IDOK, 153, 133, 60, 12, WS_TABSTOP
>> shell32_Ja.rc: DEFPUSHBUTTON "OK", IDOK, 153, 133, 60, 12, WS_TABSTOP
>> shell32_Nl.rc: DEFPUSHBUTTON "OK", IDOK, 153, 133, 60, 12, WS_TABSTOP
>> shell32_No.rc: DEFPUSHBUTTON "OK", IDOK, 153, 133, 60, 12, WS_TABSTOP
>> shell32_Pl.rc: DEFPUSHBUTTON "OK", IDOK, 153, 133, 60, 12, WS_TABSTOP
>> shell32_Pt.rc: DEFPUSHBUTTON "OK", IDOK, 153, 133, 60, 12, WS_TABSTOP
>> shell32_Pt.rc: DEFPUSHBUTTON "OK", IDOK, 153, 133, 60, 12, WS_TABSTOP
>> shell32_Ro.rc: DEFPUSHBUTTON "OK", IDOK, 153, 133, 60, 12, WS_TABSTOP
>> shell32_Ru.rc: DEFPUSHBUTTON "OK", IDOK, 153, 133, 60, 12, WS_TABSTOP
>> shell32_Sk.rc: DEFPUSHBUTTON "OK", IDOK, 153, 133, 60, 12, WS_TABSTOP
>> shell32_Sv.rc: DEFPUSHBUTTON "OK", IDOK, 153, 133, 60, 12, WS_TABSTOP
>> shell32_Uk.rc: DEFPUSHBUTTON "OK", IDOK, 153, 133, 60, 12, WS_TABSTOP
>>
>> The size of these OK buttons is probably aligned with the other button in
>> that window.

Sure. There are a lot of places (not just in what you are fixing) that
are incorrect.

I would like to go through and fix all the layout issues so that the
dialogs look nice and are consistent across all the different
languages. However, this is a *huge* job.

What I would like to do is get an automated (or semi-automated) tool,
ideally with a GUI interface to it. That would ultimately put the
designer in charge. Hopefully, this would also mean that you have a
base resource file that produces the English resources and generate
the others using the standard po files - thus making it easier to
translate.

I'm not sure how far the project should go. And, realistically, at
least the core - a command line source+po <==> resource file mapping -
should be in Wine as it will need to generate the resource files at
runtime (unless a dependency is created on that project)..

> I'm not against changing the size of that OK button to 50x14 but was merely
> pointing out that this means most of this stuff is not correct.

Sure -- see my comments above.

> FWIW I was just looking at Outlook 2003 and the OK button on the about
> window is the same wide as the other buttons (not 50). The page you
> reference doesn't say anything about adjusting sizes of buttons when
> multiple (horizontally or vertically) can be found on one page (or at least
> I didn't see it).

I'm not sure, either. However, I think that consistency is important.

- Reece