[2/2] kernel32: Fix GetVolumeNameForVolumeMountPointW to match Mountmgr
Guy Albertelli
galberte at neo.rr.com
Tue May 12 09:47:21 CDT 2009
On Sat, 2009-05-09 at 09:52 -0600, Vitaliy Margolen wrote:
> Few nitpicks about your patch.
>
> Guy Albertelli wrote:
>
> > + /* is there space in the return variable ?? */
> > + if ((o1->SymbolicLinkNameLength/sizeof(WCHAR))+2 > size)
> > + {
> > + SetLastError( ERROR_INVALID_PARAMETER );
> > + goto err_ret;
> > + }
> This doesn't look right. There are several other error codes that more
> appropriate. You should expand your tests to check what native returns here.
> Also are you sure that "size" is in chars not bytes?
You are right, should be ERROR_FILENAME_EXCED_RANGE - at least on XP.
Will cleanup rest and resubmit with additional tests
Thanks Guy
More information about the wine-devel
mailing list