comctl32/ipaddress: Skip test on Win95 with common controls 4.70 (try2)
Nikolay Sivov
bunglehead at gmail.com
Wed May 27 07:11:30 CDT 2009
Paul Vriens wrote:
> Nikolay Sivov wrote:
>>
>> + ok(hwnd != NULL, "Expected window to be created\n");
>> + if (!hwnd)
>> + {
>> + win_skip("IPAddress control not implemented\n");
>> + return;
>> + }
>>
>> /* check text just after creation */
>> r = GetWindowText(hwnd, ip, sizeof(ip)/sizeof(CHAR));
>
> I would either get rid of the ok(hwnd ...) altogether or move it after
> the if(). win_skip() means we are ok with a failure on some Windows
> boxes so a test failure just before that doesn't make sense.
>
Agreed. Try 3 should be fine.
More information about the wine-devel
mailing list