comctl32:rebar: Don't store an empty string in REBAR_InsertBandT.

Nikolay Sivov bunglehead at gmail.com
Thu May 28 14:34:16 CDT 2009


Sergey Khodych wrote:
> Nikolay Sivov пишет:
>
>>
>> It looks like you need to add a simple test like that:
>> - add band with empty string and RBBIM_TEXT mask of course;
>> - query band data back with RB_GETBANDINFO and check this lpText field.
>>
>> If it's really NULL (e.g. your buffer didn't change) instead of empty 
>> string you should test
>> RB_SETBARINFO for the same case.
>>
> It returns an empty string in both case.
So adding a band with NULL text OR empty string always returned empty 
string to getter?
Provide a test case for that please.

If it already returns empty when needed there's no point to change 
storing code.
>> What you mean saying extra space? Some offset during drawing or what?
>>
>
> If a band has an empty string, wine allocates a padding space in
> lpBand->rcCapText that causes an offset in a band.
It looks like a workaround, if get/set text behaves ok now (no tests 
exist I suppose) then
the only place to be changed is this rectangle dimensions.



More information about the wine-devel mailing list